Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix メールプラグインのメールフィールド 編集画面で、「注意書き」「説明文」の使い方がわかりにくい問題を解決 #1222

Open
wants to merge 1 commit into
base: dev-4
Choose a base branch
from
Open

fix メールプラグインのメールフィールド 編集画面で、「注意書き」「説明文」の使い方がわかりにくい問題を解決 #1222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions lib/Baser/Plugin/Mail/View/MailFields/admin/form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,16 @@
<?php echo $this->BcForm->error('MailField.valid') ?>
</td>
</tr>
<tr id="RowAttention">
<th class="col-head"><?php echo $this->BcForm->label('MailField.attention', __d('baser', '注意書き')) ?></th>
<tr id="RowDescription">
<th class="col-head">
<?php echo $this->BcForm->label('MailField.description', __d('baser', '説明文')) ?>
<br><small>※ 送信しない前見出し</small>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katokaisya 説明文を前に置くか後ろに置くかはテンプレートの組み方次第なので記述するのは難しいかと思います。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katokaisya 送信しないかどうかもテンプレートの組み方次第なんですよね

<?php echo $this->BcHtml->image('admin/icn_help.png', array('id' => 'helpDescription', 'class' => 'btn help', 'alt' => __d('baser', 'ヘルプ'))) ?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katokaisya ヘルプは、 th ではなく、 td に配置するように統一されていますので td 側に置くようにしてください。

<div id="helptextDescription" class="helptext"> <?php echo __d('baser', '姓・名などメール本文に入れない内容を入力してください。')?> </div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katokaisya 「姓・名など」では、ちょっと意味が伝わりづらいかもしれません。
「この項目について、標準では送信メールには表示しません。」といった感じでしょうか。

</th>
<td class="col-input">
<?php echo $this->BcForm->input('MailField.attention', array('type' => 'textarea', 'cols' => 35, 'rows' => 3)) ?>
<?php echo $this->BcForm->error('MailField.attention') ?>
<?php echo $this->BcForm->input('MailField.description', array('type' => 'textarea', 'cols' => 35, 'rows' => 3)) ?>
<?php echo $this->BcForm->error('MailField.description') ?>
</td>
</tr>
<tr id="RowBeforeAttachment">
Expand All @@ -117,11 +122,16 @@
<?php echo $this->BcForm->error('MailField.after_attachment') ?>
</td>
</tr>
<tr id="RowDescription">
<th class="col-head"><?php echo $this->BcForm->label('MailField.description', __d('baser', '説明文')) ?></th>
<tr id="RowAttention">
<th class="col-head">
<?php echo $this->BcForm->label('MailField.attention', __d('baser', '注意書き')) ?>
<br><small>※ 送信しない後見出し</small>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「※ 送信メールには表示されません」に変更

<?php echo $this->BcHtml->image('admin/icn_help.png', array('id' => 'helpAttention', 'class' => 'btn help', 'alt' => __d('baser', 'ヘルプ'))) ?>
<div id="helptextAttention" class="helptext"> <?php echo __d('baser', '「確認のためもう一度入力してください」などメール本文に入れない内容を入力してください。')?> </div>
</th>
<td class="col-input">
<?php echo $this->BcForm->input('MailField.description', array('type' => 'textarea', 'cols' => 35, 'rows' => 3)) ?>
<?php echo $this->BcForm->error('MailField.description') ?>
<?php echo $this->BcForm->input('MailField.attention', array('type' => 'textarea', 'cols' => 35, 'rows' => 3)) ?>
<?php echo $this->BcForm->error('MailField.attention') ?>
</td>
</tr>
<tr id="RowSource">
Expand Down