Set model_origin when creating chains #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidarth
changed the title
marius-baseten
approved these changes
Jun 14, 2024
truss/remote/baseten/api.py
Outdated
| ) {{ | ||
| id, | ||
| name, | ||
| version_id | ||
| }} | ||
| }} | ||
| """ | ||
|
|
||
| print(query_string) |
truss-chains/truss_chains/deploy.py
Outdated
| @@ -251,6 +253,7 @@ def deploy_remotely( | |||
| chainlet_name_to_url[chainlet_descriptor.name] = "http://dummy" | |||
|
|
|||
| if isinstance(options, definitions.DeploymentOptionsBaseten): | |||
|
|
|||
There was a problem hiding this comment.
Do you find these blank lines make the file more readable?
There was a problem hiding this comment.
this was an accident
truss/remote/baseten/remote.py
Outdated
| ) -> BasetenService: | ||
| print(f"IN push: {origin} ") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What
As a follow-up to https://github.com/basetenlabs/baseten/pull/8584, actually want to start setting the model origin so that chains models are excluded from the main models view
💻 How
🔬 Testing
Ran:
Ensured that the model origin was set on the deployed models.