Add NanoBoyAdvance v35

[liberodark]

Build OK

[nadenislamarre]

i mark it for v34, ok ?

[liberodark]

Yes is for v34
thank for the tag

[zognic]

great sound improvement, very good alternative for GBA Emulation

[nadenislamarre]

conflicting ;-(

[liberodark]

Fixed @nadenislamarre

[nadenislamarre]

needs to be patched to avoid hacks like
copy_tree(nba_Config, nba_Homedir)

features: [padtokeyboard, decoration]
shared: [hud]
is no more valid.

features decoration must not be used anymore. (due to very recent changes)

[nadenislamarre]

@liberodark why to you need to copy /usr/nba/ ?

[liberodark]

@nadenislamarre It's like redream it needs to be present with its files otherwise it won't work.
Also have remove decoration and update this part.

[nadenislamarre]

but contrary to redream, it can be fixed while sources are here.

[Hew-ux]

Tried building this branch. Pulled it in, rebased from master, resolved the conflicts and added it to GeneratorImporter.py. Crashes when attempting to launch, here is stderr:

2022-06-23 22:21:15,006 ERROR (emulatorlauncher:564):<module> configgen exception:
Traceback (most recent call last):
  File "/usr/bin/emulatorlauncher", line 562, in <module>
    exitcode = main(args, maxnbplayers)
  File "/usr/bin/emulatorlauncher", line 97, in main
    return start_rom(args, maxnbplayers, args.rom, args.rom)
  File "/usr/bin/emulatorlauncher", line 155, in start_rom
    wantedGameMode = generator.getResolutionMode(system.config)
AttributeError: 'tuple' object has no attribute 'getResolutionMode'

Notably this seems unrelated to the NbaGenerator itself, as NbaGenerator.py correctly calls for 'getResolution' and not 'getResolutionMode'.

[Hew-ux]

Changes needed for the updates to configgen in v35: master...Hew-ux:nanoboy-rebased

[lbrpdx]

This is conflicting for v35. What is the interest of adding NanoBoy Advance compared to mgba or vba-m? Again, we're nearing the limit of what the system can support before having everyone to re-partition again,

[Hew-ux]

@lbrpdx the interest I believe is more accurate emulation and less audio clipping.

[nadenislamarre]

copy_tree must be avoided.