Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tar): allow --action_env to override LC_ALL #1019

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(tar): allow --action_env to override LC_ALL #1019

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e4b065
fix(tar): allow --action_env to override LC_ALL
alexeagle Dec 19, 2024
8bba028
Update tar.bzl
alexeagle Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/private/tar.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,10 @@ def _tar_impl(ctx):
mnemonic = "Tar",
unused_inputs_list = unused_inputs_file,
toolchain = "@aspect_bazel_lib//lib:tar_toolchain_type",
# Allow users to set --action_env=LC_ALL=C.UTF-8 for example,
# on systems where default locale is wrong.
# See https://github.com/bazelbuild/bazel-central-registry/issues/2256
use_default_shell_env = True,
)

# TODO(3.0): Always return a list of providers.
Expand Down
Loading