Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run cc_tests with a hermetic musl dynamic linker #39

Merged
merged 15 commits into from
Aug 24, 2024
Merged

Run cc_tests with a hermetic musl dynamic linker #39

merged 15 commits into from
Aug 24, 2024

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Aug 20, 2024 •
edited
Loading

Defines custom cc_test toolchains to ensure that:

  • the cc_test binary is invoked with the musl dynamic linker if linked dynamically
  • the test is run on an execution platform with the correct OS and CPU (but not necessarily musl preinstalled)

@fmeum fmeum force-pushed the dynamic-musl branch 3 times, most recently from d9270fd to aa17cd7 Compare August 20, 2024 21:11
@fmeum fmeum requested a review from illicitonion August 22, 2024 12:30
@fmeum fmeum marked this pull request as ready for review August 22, 2024 12:30
illicitonion
illicitonion approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fmeum fmeum enabled auto-merge (squash) August 23, 2024 13:21
@fmeum fmeum merged commit 8d24006 into main Aug 24, 2024
13 checks passed
@fmeum fmeum deleted the dynamic-musl branch August 24, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @illicitonion