fix: integrity in snapshot test #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrindel
approved these changes
Nov 25, 2024
| @@ -545,7 +545,7 @@ bcr_test_module: | |||
| modules/zip/1.0.0/source.json | |||
| ---------------------------------------------------- | |||
| { | |||
| \\"integrity\\": \\"sha256-Bqu+8wSwNVkplPEHcMNdla+oQRGoyXfx4BohYHCPZFU=\\", | |||
| \\"integrity\\": \\"sha256-fencLRegfGaNYdAWP/WaXxUWJwzD19XQtpWf2qcmkZw=\\", | |||
There was a problem hiding this comment.
Do we need to document which environment this represents?
There was a problem hiding this comment.
I haven't quite figured it out, except that the zips produces on my mac laptop match the ones produces on CI (ubuntu), but do not match the ones produced on my ubuntu laptop 😳. This is only test code though, nothing used in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test code that produces the zip doesn't produce the same output on all platforms. Until that's fixed, update to what passes on CI.