Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix a layer violation causing a circular dependency #192

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

kormide
Copy link
Collaborator

@kormide kormide commented Jan 8, 2025

Remove references from the domain layer out of the infrastructure layer. This caused circular dependencies when converting this repo to build with bazel.

@kormide kormide marked this pull request as ready for review January 8, 2025 06:13
@kormide kormide requested review from alexeagle and cgrindel January 8, 2025 06:13
src/infrastructure/github.ts Show resolved Hide resolved
@kormide kormide merged commit a68a9c6 into main Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants