Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rules_shell loads where needed #401

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add rules_shell loads where needed #401

merged 2 commits into from
Nov 26, 2024

Conversation

ted-xie
Copy link
Contributor

@ted-xie ted-xie commented Nov 26, 2024 •
edited by cgrindel
Loading

@cgrindel cgrindel assigned cgrindel and unassigned cgrindel Nov 26, 2024
@cgrindel cgrindel self-requested a review November 26, 2024 20:44
@cgrindel cgrindel merged commit 113eecb into bazel-contrib:main Nov 26, 2024
5 checks passed
@ted-xie
Copy link
Contributor Author

ted-xie commented Nov 26, 2024

@cgrindel Thanks for approving this so quickly! If it's not too much trouble, would you mind also creating a new release that includes this commit?

@cgrindel
Copy link
Member

Working on it. I need #402 to merge before I can create a release.

@cgrindel
Copy link
Member

Release 0.27.0 is out. If you use bzlmod, you will need to wait until the BCR PR merges.

@aignas
Copy link

aignas commented Dec 10, 2024

I think sh_library load is also needed in

rules_bazel_integration_test/tools/BUILD.bazel

Line 14 in d3e578b

sh_library(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrindel cgrindel cgrindel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing sh_binary loads for Bazel 9 support
3 participants
@ted-xie @cgrindel @aignas