refactor: split monolithic BUILD.local_cuda into template fragments #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudhan
force-pushed
the
cloudhan/hermetic-ctk-1
branch
3 times, most recently
from
b7887dd to
9953aba
Compare
cloudhan
force-pushed
the
cloudhan/hermetic-ctk-1
branch
3 times, most recently
from
b886a49 to
255a4df
Compare
cloudhan
force-pushed
the
cloudhan/hermetic-ctk-1
branch
from
255a4df to
31495ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #283
This breaks the monolithic
BUILD.local_cudainto smaller fragments.For non hermatic
local_cudarepo with local CTK, thelocal_cudarepo will be instantiate by automatically pasting the fragments back again into a singleBUILDfile.For hermatic
local_cudarepo (in this case,localto the host env) with deliverable components in latter comming PRs, thelocal_cudarepo is our entry point to access cuda toolkit. Each component will instantiate a repo for that component only. TheBUILDfile only contains the fragment for the very component. The targets will then be aliased back to thelocal_cudarepo as an user interface.