Update protoc plugins to support Protobuf Editions #4236
+32
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this! CI is red with a reference to googleapis. Maybe we need to add a dep? |
|
@fmeum I also had to update |
The new version splits out google.golang.org/genproto/googleapis/rpc which resolves the missing dependency CI error. Also running go mod tidy to cleanup unused sums.
|
Do you happen to know whether these updates include any breaking changes (especially in protobuf)? I'm asking because an alternative approach that avoids a forceful update for users would be to document that contents of Go proto rules need to depend on a sufficiently recent protobuf version themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This adds support for compiling
go_proto_libraryandgo_grpc_libraryto support .proto files using Protobuf Editions.Which issues(s) does this PR fix?
Fixes #4235
Other notes for review