Represent test timeouts in XML #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
timeouts-in-xml
branch
from
f225159 to
cb7206c
Compare
illicitonion
force-pushed
the
timeouts-in-xml
branch
from
cb7206c to
e09bda3
Compare
This creates similar output as bazelbuild/bazel@7b091c1
illicitonion
force-pushed
the
timeouts-in-xml
branch
from
e09bda3 to
15cd495
Compare
shs96c
reviewed
Feb 9, 2024
| private final Object resultsLock = new Object(); | ||
| // Commented out to avoid adding a dependency to building the test runner. | ||
| // This is really just documentation until someone actually turns on a static analyser. | ||
| // If they do, we can decide whether we want to pick up the dependency. |
There was a problem hiding this comment.
We won't. Keeping pristine classpaths is a difficult trick to pull off.
| private String reason; | ||
| private TestExecutionResult result; | ||
| TestExecutionResult result; |
There was a problem hiding this comment.
Why change the visibility? If this needs to be package private for some reason, can we document why?
illicitonion
added a commit
that referenced
this pull request
Feb 13, 2024
This creates similar output as bazelbuild/bazel@7b091c1 Note: This is a duplicate of #242, but with the comments addressed and the merge conflicts resolved. --------- Co-authored-by: Daniel Wagner-Hall <[email protected]>
|
Merged in #247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates similar output as bazelbuild/bazel@7b091c1