Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove diagnostic warning if force_version is set #1333

Open
fzakaria opened this issue Feb 24, 2025 · 0 comments · May be fixed by #1334
Open

Remove diagnostic warning if force_version is set #1333

fzakaria opened this issue Feb 24, 2025 · 0 comments · May be fixed by #1334

Comments

@fzakaria
Copy link

Our developers get concerned when they see messages like:

Please remove duplicate artifacts from the artifact list so you do not get unexpected artifact versions

This message can be present even though we use set_version such as in

use_repo(maven, "maven", "rules_proto_grpc_java_maven")
maven.artifact(
    name = "rules_proto_grpc_java_maven",
    artifact = "protobuf-java",
    force_version = True,
    group = "com.google.protobuf",
    version = "3.25.5",
)
maven.artifact(
    name = "rules_proto_grpc_java_maven",
    artifact = "protobuf-java-util",
    force_version = True,
    group = "com.google.protobuf",
    version = "3.25.5",
)

I think a good improvement to the UX would be to not display this message if there are duplicate versions only if only one of them has force_version set.
fzakaria added a commit to fzakaria/rules_jvm_external that referenced this issue Feb 24, 2025
@fzakaria
Do not warn on duplicate entries if force_version set
8822606 
fixes bazel-contrib#1333
@fzakaria fzakaria linked a pull request Feb 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not warn on duplicate entries if force_version set fzakaria/rules_jvm_external
1 participant
@fzakaria