Do not warn on duplicate entries if force_version set #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
reviewed
Mar 3, 2025
| Convert an artifact to a maven coordinate string. | ||
| """ | ||
|
|
||
| return artifact["group"] + ":" + artifact["artifact"] + (":%s" % artifact["classifier"] if artifact.get("classifier") != None else "") |
There was a problem hiding this comment.
The coordinate handling code is now in //private/lib:coordinates.bzl. You likely want to use to_external_form here, or perhaps add an additional function.
| seen_artifacts[artifact_coordinate] = artifact | ||
|
|
||
| # go through the duplicate_artifacts and if the list of artifacts contains exactly one with force_version set to True | ||
| # remove it from teh duplicate_artifacts entry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment coursier to detect if
force_versionis set on a single artifact and omit the warning then.fixes #1333