Use rules_android_ndk #1302
Closed
Use rules_android_ndk #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: utzcoz <[email protected]>
Signed-off-by: utzcoz <[email protected]>
Signed-off-by: utzcoz <[email protected]>
utzcoz
force-pushed
the
use-rules_android_ndk
branch
from
12f34b9 to
046f417
Compare
It copied from rules_android_ndk/.bazelci/presubmit.yml. Signed-off-by: utzcoz <[email protected]>
|
I'm pretty sure we don't use the NDK for developing the project or even for downstream users who download aar artifacts -- or at least, we shouldn't incur this dependency. It's an incidental complexity, and I think the right fix is to remove the dep altogether. #1305 is an attempt. |
|
@jin Thanks for the explanation. I will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to execute
REPIN=1 bazel run @maven//:pin, theandroid_ndk_repositorytells me that it can't recognizeRELEASE.TXTfile orplatformsdirectory when exposing latest Android Ndk withANDROID_NDK_HOME.After investigation, if we want to use Android NDK rc22+, we need to use
rules_android_ndk, and this module has been released with version 1.0.2, also included into bazel central registry. So this CL just switchs to userules_android_ndklatest stable version, and adds necessary rules_cc thatrules_android_ndkrequires. With it, I can run repin command to generate extra changes formaven_install.json.I am not familiar with bzlmod and rules_jvm_external requirements for external dependencies very much , so please tell me if I did something wrong.