Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf to 29.3 (bzlmod only) #1314

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Update protobuf to 29.3 (bzlmod only) #1314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,15 @@ http_file(

bazel_dep(
name = "protobuf",
# Note: we use 27.2 in MODULE.bazel to avoid the warning:
# The maven repository 'maven' is used in two different bazel modules, originally in 'rules_jvm_external' and now in 'protobuf'
# But we use 21.7 in WORKSPACE because protobuf 27.2 doesn't work with Bazel 5.x
# Note: In MODULE.bazel, we use a version >= 29.1 to avoid polluting the
# default maven repo name with protobuf's dependencies.
# https://github.com/protocolbuffers/protobuf/pull/19477
# However, in WORKSPACE, we use version 21.7 since version 27.2 doesn't work
# with Bazel 5.x.
# https://github.com/protocolbuffers/protobuf/commit/a80daa2a2caaaac9ebe9ae6bb1b639c2771c5c55
# This should be ok because we only use the protobuf dep to pull in the google/protobuf/wrappers.proto for testing
version = "27.2",
# This should be ok because we only use protobuf to pull in the google/protobuf/wrappers.proto
# for testing.
version = "29.3",
dev_dependency = True,
)
bazel_dep(
Expand Down