refactor: update node toolchain to provider File objects instead of paths #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
nodejs_toolchain_improvements
branch
2 times, most recently
from
0fe2279 to
9792ad3
Compare
gregmagolan
force-pushed
the
nodejs_toolchain_improvements
branch
18 times, most recently
from
8629f53 to
b6b8b8f
Compare
|
Tested this on rules_js 2.0 branch: aspect-build/rules_js#1557. |
gregmagolan
force-pushed
the
nodejs_toolchain_improvements
branch
from
b6b8b8f to
d28957a
Compare
|
I think a 7.0 of rules_nodejs is very undesirable. Breaking changes low in the depgraph have always been a major hassle for us and don't work well for users. It would need a lot of devrel care and attention that we don't have much time for. |
|
Replaced by #3736 which maintains backward compat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES intended for rules_nodejs 7.0 and rules_js 2.0.
To-date the node toolchain has provided paths (strings) to node and npm. This complicates downstream usage as they need to convert these paths depending on they are used (between execpath and rootpath for example). This change configures the toolchain to instead provide File objects for node and the npm entry point script so downsteam uses can choose to get either the
.pathor.short_pathas needed.Does this PR introduce a breaking change?