chore: upgrade to Bazel 7.1.1 #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
bump_bazel_version
branch
3 times, most recently
from
9ed8cc8 to
64e2c31
Compare
jbedard
reviewed
Apr 2, 2024
| # Note, this gets the default version of Node.js from | ||
| # https://github.com/bazelbuild/rules_nodejs/blob/5.8.0/nodejs/repositories.bzl#L11 | ||
| node.toolchain( | ||
| name = "node16", |
There was a problem hiding this comment.
Why drop this when upgrading bazel?
There was a problem hiding this comment.
I mentioned it in the PR summary. Getting to bazel means the bzlmod by default and that means the default toolchain is used which is Node 18. Node 18 doesn't run on the Bazel CI runners because it requires a newer version of GLIBC.
There was a problem hiding this comment.
The PR summary says nothing about the toolchain name. Why change the name making the diff 10x larger?
gregmagolan
force-pushed
the
bump_bazel_version
branch
from
64e2c31 to
9e0bc53
Compare
mattem
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up the e2e/smoke bzlmod test as well. The default Node.js version of 18 breaks on Bazel CI due to GLIBC incompatibility with the runner so default Node.js must be < 18.