fix: support node_version_from_nvmrc with bzlmod #3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
support_bzlmod_use_nvmrc
branch
4 times, most recently
from
bb324ad to
11437b8
Compare
gregmagolan
changed the title
gregmagolan
force-pushed
the
support_bzlmod_use_nvmrc
branch
from
11437b8 to
f68905e
Compare
|
Can we reduce the diff to just the core change? I'm not sure what half the diff is from... |
I explained in the PR summary. The corresponding change to adding |
gregmagolan
force-pushed
the
support_bzlmod_use_nvmrc
branch
from
f68905e to
4ffbafc
Compare
gregmagolan
force-pushed
the
support_bzlmod_use_nvmrc
branch
from
4ffbafc to
570ab75
Compare
alexeagle
approved these changes
Apr 2, 2024
|
@gregmagolan I understand what the change is, that's simple, I don't understand why the diff on the PR needs to be so big though? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
node_version_from_nvmrcattribute to bzlmod and deprecate old naming ofuse_nvmrcused in WORKSPACE.node_version_from_nvmrcnaming follows the convention from rules_ts where a similar attribute is namedts_version_fromand is more accurate and self-documenting.