perf: make registry output to bazel-out #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
commented
Aug 4, 2023
thesayyn
commented
Aug 4, 2023
thesayyn
commented
Aug 4, 2023
thesayyn
commented
Aug 4, 2023
thesayyn
force-pushed
the
registry_perf
branch
from
ed5055a to
41a0576
Compare
|
this is unblocked now; #424 |
thesayyn
force-pushed
the
registry_perf
branch
from
3d9b66b to
125c19c
Compare
thesayyn
force-pushed
the
registry_perf
branch
3 times, most recently
from
b856ded to
e0ab631
Compare
thesayyn
commented
Nov 30, 2023
thesayyn
force-pushed
the
registry_perf
branch
from
e0ab631 to
9d105dc
Compare
alexeagle
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively eliminates the filesystem calls needed to copy the final image from the registry storage to the final output directory (bazel-out).
Partially addresses: #365
There's still room for performance improvement for oci_image targets with
base, which is hard linking individual blobs from the base image to the output directory directly to eliminate fs copy calls for loading base image onto the registry as well. however, i am not sure how well that would work with Sandox and RBE. I'll leave that as a follow-up.