Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support RBE #65

Merged
merged 1 commit into from
Jan 17, 2024
Merged

feat: support RBE #65

merged 1 commit into from
Jan 17, 2024

Conversation

p0deje
Copy link
Member

@p0deje p0deje commented Jan 15, 2024

This allows to build/run/test on the RBE environment at least for JRuby.

@p0deje p0deje force-pushed the rbe branch 4 times, most recently from b40ea9f to a531990 Compare January 15, 2024 22:30
@p0deje p0deje requested a review from alexeagle January 15, 2024 22:31
alexeagle
alexeagle approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add an RBE row in our test matrix so we know if this regresses?

@p0deje
Copy link
Member Author

p0deje commented Jan 17, 2024

Maybe we should add an RBE row in our test matrix so we know if this regresses?

Any tips how to test it on CI?

@p0deje
feat: support RBE
afaf872 
This is known to work for JRuby only at the moment.
@p0deje p0deje merged commit 71a8048 into main Jan 17, 2024
41 checks passed
@p0deje p0deje deleted the rbe branch January 17, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0deje @alexeagle