feat: Support cross compiles from linux to macos #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstreaming an internal patch we've been using for cross compiling the aspect CLI from a linux machine to mac. We've been using a slightly different version of this for quite some time now so I cleaned up the logic significatly so it could be upstreamed.
keith
reviewed
Feb 10, 2025
fmeum
approved these changes
Feb 10, 2025
fmeum
reviewed
Feb 10, 2025
While this was part of our original patch, it really only helps give warning messages for sysroot version mismatches. Remove for now since its not really important to the core logic of the change.
mrmeku
force-pushed
the
mrmeku-cross-compile-linux-to-darwin
branch
from
b0ff8f6 to
830c14b
Compare
fmeum
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming an internal patch we've been using
for cross compiling the aspect CLI from a linux
machine to mac. We've been using a slightly
different version of this for quite some time
now so I cleaned up the logic significatly so it
could be upstreamed.