-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include additional rule info while exporting builtins #21135
base: master
Are you sure you want to change the base?
Include additional rule info while exporting builtins #21135
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
05c174a
to
5fd15b2
Compare
@sgowroji Any pointers on getting CI to pass? Looks like a potential flake but I can't see the retry button in the usual place in the Buildkite UI. |
Retried and looks good now. |
Thank you! |
5fd15b2
to
187fce3
Compare
I don't think we should continue trying to represent a native rule class as a callable See also discussion in #21929 |
My WIP Starlark LSP currently uses the ApiExporter to dump all types + globals to the
builtins.pb
proto, which the LSP then loads at runtime to provide type information/hover docs for Bazel builtins. Right now, theApiExporter
only sets thename
andis_mandatory
fields of ruleParam
s, limiting the ability of the LSP to provide type checking for rules (e.g. validating argument types). This PR adds additional getters onRuleDocumentationAttribute
for the attribute type, default value, documentation, allowing the LSP to use this additional information.