-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add starlark debugger python script interface #24814
base: master
Are you sure you want to change the base?
Add starlark debugger python script interface #24814
Conversation
fc6c872
to
704d1ff
Compare
f64ceff
to
1b2ff96
Compare
See discussion in #13387. |
167a9b4
to
540849b
Compare
Looks like this could be useful to many folks, thanks for open-sourcing this! However, it's not clear to me why this needs to be added to the Bazel codebase. Is there any reason you'd rather not host this in a repository you own? If the worry is going out-of-sync with changes to the debugger protocol, we could consider adding this to our downstream CI. If ease-of-discovery is a concern, we could link this from the documentation somewhere. |
This patch will add a python script interface to the debugger together with the following tools: * Interactive debugger * Trace tool See README.md for more information
540849b
to
dff6652
Compare
This has been starved for a while and when I saw new interest in the starlark debugger a PR was most feasible way for me right now to get it "out there" for comments and for people to reach the code. I also saw similar scripts (like ctexplain) were added to the tools section.
Awesome suggestions. Thanks. There is a number of factors talking for a separate repo also:
Usually you want the "latest" version of a debugging tool even if you bisecting Bazel or using an earlier version of it. There is a few integration issues to solve in a separate repo solution for the user experience to be as seamless as applying this patch and build the dependencies (as well as the same bandwidth issues that has delayed this to begin with). |
This patch will add a python acript interface to the debugger together with the following tools:
See README.md for more information