Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No format for tabular data #1216

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

systemlogic
Copy link

Not in all cases formatting of build data / code is required. Code can be written in a way which looks beautiful and easy to spot problem when maintained in tabular format using certain spacing between columns. Current implementation of buildfier results in loosing well formatted code( manually maintained) which has been needed in tabular code.

Not in all cases formatting of build data / code is required. Code can be written in a way which looks beautiful and easy to spot problem when maintained in tabular format using certain spacing between columns. Current implementation of buildfier results in loosing well formatted code( manually maintained) which has been needed in tabular code.
@aiuto
Copy link
Contributor

aiuto commented Nov 10, 2023

This seems to change the whitespace of nearly every line. Did your editor save tabs as spaces?

@systemlogic
Copy link
Author

systemlogic commented Nov 14, 2023

This seems to change the whitespace of nearly every line. Did your editor save tabs as spaces?

No such settings in my vim editor, which saves tabs as spaces.

However our own internal parser works with precision of spaces and all such tabular code need to be separated with spaces. In other words, no formatting from buildifier.

@systemlogic
Copy link
Author

@aiuto ping for review request.

@mzeren-vmw
Copy link

FWIW, we are using an internal version of #985. That patch needs to be rebased and reworked. Importantly for us it supports sorting by a particular column.

@systemlogic
Copy link
Author

@pmbethe09 @larsrc-google @vladmos @aiuto

I am curious to know if anything is pending?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants