Skip to content

Commit

Permalink
rename is_nostd to is_no_std
Browse files Browse the repository at this point in the history
  • Loading branch information
fionera authored Jan 27, 2025
1 parent 4062960 commit 454e383
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions docs/src/rust_prost.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ A rule for generating a Rust library using Prost.
## rust_prost_toolchain

<pre>
rust_prost_toolchain(<a href="#rust_prost_toolchain-name">name</a>, <a href="#rust_prost_toolchain-include_transitive_deps">include_transitive_deps</a>, <a href="#rust_prost_toolchain-is_nostd">is_nostd</a>, <a href="#rust_prost_toolchain-prost_opts">prost_opts</a>, <a href="#rust_prost_toolchain-prost_plugin">prost_plugin</a>,
rust_prost_toolchain(<a href="#rust_prost_toolchain-name">name</a>, <a href="#rust_prost_toolchain-include_transitive_deps">include_transitive_deps</a>, <a href="#rust_prost_toolchain-is_nostd">is_no_std</a>, <a href="#rust_prost_toolchain-prost_opts">prost_opts</a>, <a href="#rust_prost_toolchain-prost_plugin">prost_plugin</a>,
<a href="#rust_prost_toolchain-prost_plugin_flag">prost_plugin_flag</a>, <a href="#rust_prost_toolchain-prost_runtime">prost_runtime</a>, <a href="#rust_prost_toolchain-prost_types">prost_types</a>, <a href="#rust_prost_toolchain-proto_compiler">proto_compiler</a>, <a href="#rust_prost_toolchain-tonic_opts">tonic_opts</a>,
<a href="#rust_prost_toolchain-tonic_plugin">tonic_plugin</a>, <a href="#rust_prost_toolchain-tonic_plugin_flag">tonic_plugin_flag</a>, <a href="#rust_prost_toolchain-tonic_runtime">tonic_runtime</a>)
</pre>
Expand All @@ -180,7 +180,7 @@ Rust Prost toolchain rule.
| :------------- | :------------- | :------------- | :------------- | :------------- |
| <a id="rust_prost_toolchain-name"></a>name | A unique name for this target. | <a href="https://bazel.build/concepts/labels#target-names">Name</a> | required | |
| <a id="rust_prost_toolchain-include_transitive_deps"></a>include_transitive_deps | Whether to include transitive dependencies. If set to True, all transitive dependencies will directly accessible by the dependent crate. | Boolean | optional | `False` |
| <a id="rust_prost_toolchain-is_nostd"></a>is_nostd | If a no_std tag should be put into the generated code. | Boolean | optional | `False` |
| <a id="rust_prost_toolchain-is_nostd"></a>is_no_std | If a no_std tag should be put into the generated code. | Boolean | optional | `False` |
| <a id="rust_prost_toolchain-prost_opts"></a>prost_opts | Additional options to add to Prost. | List of strings | optional | `[]` |
| <a id="rust_prost_toolchain-prost_plugin"></a>prost_plugin | Additional plugins to add to Prost. | <a href="https://bazel.build/concepts/labels">Label</a> | required | |
| <a id="rust_prost_toolchain-prost_plugin_flag"></a>prost_plugin_flag | Prost plugin flag format. (e.g. `--plugin=protoc-gen-prost=%s`) | String | optional | `"--plugin=protoc-gen-prost=%s"` |
Expand Down
8 changes: 4 additions & 4 deletions extensions/prost/private/prost.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ def _compile_proto(
additional_args.add("--additional_srcs={}".format(",".join([f.path for f in all_additional_srcs.to_list()])))
additional_args.add_all(prost_toolchain.prost_opts + prost_opts, format_each = "--prost_opt=%s")

if prost_toolchain.is_nostd:
additional_args.add("--is_nostd")
if prost_toolchain.is_no_std:
additional_args.add("--is_no_std")

if prost_toolchain.tonic_plugin:
tonic_plugin = prost_toolchain.tonic_plugin[DefaultInfo].files_to_run
Expand Down Expand Up @@ -445,7 +445,7 @@ def _rust_prost_toolchain_impl(ctx):
tonic_plugin_flag = ctx.attr.tonic_plugin_flag,
tonic_runtime = ctx.attr.tonic_runtime,
include_transitive_deps = ctx.attr.include_transitive_deps,
is_nostd = ctx.attr.is_nostd,
is_no_std = ctx.attr.is_no_std,
)]

rust_prost_toolchain = rule(
Expand All @@ -457,7 +457,7 @@ rust_prost_toolchain = rule(
doc = "Whether to include transitive dependencies. If set to True, all transitive dependencies will directly accessible by the dependent crate.",
default = False,
),
"is_nostd": attr.bool(
"is_no_std": attr.bool(
doc = "If a no_std tag should be put into the generated code.",
default = False,
),
Expand Down
4 changes: 2 additions & 2 deletions extensions/prost/private/protoc_wrapper.rs
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,10 @@ fn generate_lib_rs(
is_tonic: bool,
direct_dep_crate_names: Vec<String>,
additional_content: String,
is_nostd: bool,
is_no_std: bool,
) -> String {
let mut contents = vec![
if is_nostd {
if is_no_std {
"#![no_std]".to_string()
} else {
"".to_string()
Expand Down

0 comments on commit 454e383

Please sign in to comment.