Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rustfmt on crates with generated sources #2255

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Support rustfmt on crates with generated sources #2255

merged 3 commits into from
Nov 16, 2023

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Nov 11, 2023 •
edited
Loading

closes #2254

@UebelAndre UebelAndre mentioned this pull request Nov 11, 2023
Closed
@UebelAndre UebelAndre force-pushed the rustfmt branch 3 times, most recently from 85e48e7 to d653b4e Compare November 13, 2023 16:01
@UebelAndre UebelAndre marked this pull request as ready for review November 13, 2023 16:02
@UebelAndre UebelAndre enabled auto-merge (squash) November 13, 2023 17:14
@UebelAndre UebelAndre requested a review from scentini November 16, 2023 04:22
scentini
scentini approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@scentini scentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre merged commit ce1b842 into bazelbuild:main Nov 16, 2023
2 checks passed
@UebelAndre UebelAndre deleted the rustfmt branch November 16, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scentini scentini scentini approved these changes

@illicitonion illicitonion Awaiting requested review from illicitonion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@rules_rust//:rustfmt tool fails on crates with generated sources
2 participants
@UebelAndre @scentini