Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new presubmit environment for bzlmod #2309

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

matts1
Copy link
Contributor

@matts1 matts1 commented Dec 8, 2023

Add an environment which builds without a workspace file.

This will allow us to verify that targets such as cargo_bazel can build with bzlmod. This is mainly useful to ensure that your dependencies are specified in MODULE.bazel, rather than WORKSPACE. At the moment, I only specify a single target, to verify that it's working. As we start supporting additional targets, entries will be added here to prevent regressions.

@matts1 matts1 force-pushed the new_env branch 4 times, most recently from 71c53fe to 3bdcc09 Compare December 8, 2023 02:06
…ace file.

Change-Id: Iddfa2f603ca13e1c0285cae8f2ecd7c5c5241b5a
@matts1 matts1 marked this pull request as ready for review December 8, 2023 02:38
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for all the work you've been putting in here!

.bazelci/presubmit.yml Show resolved Hide resolved
@illicitonion illicitonion merged commit 6874b8d into bazelbuild:main Dec 8, 2023
2 checks passed
@matts1 matts1 deleted the new_env branch December 10, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants