-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BADGERS-575: [BREAKING] Audio Described Unification #365
Open
ShiningTrapez
wants to merge
254
commits into
master
Choose a base branch
from
BADGERS-575
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📺 What
Support a "Generic" method of providing an, alternative, Audio Described stream with a new Media Block consisting of alternative sources which can be switched to and from mid stream. This approach is primarily intended for Native Strategy Devices but can work on any device given the streams are present and passed correctly (Assuming the device can play the stream and so on).
🛠 How
Refactor
MediaSources
to keep track of and index into a record of Connection Types, the design has been left open to make further additions along these lines easy in the future.Expose a new, Unified, Audio Described API which can seamlessly be used with both this implementation, and the MSE Specific Implementation:
registerForAudioDescribedChanges
(PreviouslyregisterForBroadcastMixADChanges
)unregisterForAudioDescribedChanges
(PreviouslyunregisterForBroadcastMixADChanges
)isAudioDescribedAvailable
(PreviouslyisBroadcastMixADAvailable
)isAudioDescribedEnabled
(PreviouslyisBroadcastMixADEnabled
)setAudioDescribed
(PreviouslysetBroadcastMixADEnabled
)Adds a new
enableAudioDescribed
option to Bigscreen's Init Options to start up with the AD Stream.Various QoL Fixes and Refactors as encountered during development.
enableAudioDescribed
throughMediaSources
testsPlayerComponent
testsaudio-described-cdns-available
in Chronicle and just add it tocdns-available
when AD Stream is active? (Testers commented that current setup is confusing)🚨 BROKEN