Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stash before running prepush hook tests #368

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Stash before running prepush hook tests #368

merged 1 commit into from
Feb 13, 2025

Conversation

ShiningTrapez
Copy link
Contributor

📺 What
Runs git stash push -qu before the prepush hook tests and runs git stash pop -q after them. This allows for unstaged in development tests to be present without having to pass whilst still verifying what is being pushed. Prevents potentially running --no-verify or similar to just get something pushed.

🛠 How
Source Control

✅ Testing
Tested by changing a test to fail (expect(true).toBe(false)) and not staging it whilst pushing this change - test was not included in index and did not affect prepush hook checks.

@ShiningTrapez ShiningTrapez added the semver patch This PR is a semver patch release label Feb 13, 2025
@ShiningTrapez ShiningTrapez self-assigned this Feb 13, 2025
@ShiningTrapez ShiningTrapez requested a review from a team as a code owner February 13, 2025 08:35
@ShiningTrapez ShiningTrapez merged commit a36419c into master Feb 13, 2025
4 checks passed
@ShiningTrapez ShiningTrapez deleted the gitstash branch February 13, 2025 12:40
tom-coward added a commit that referenced this pull request Feb 18, 2025
tom-coward added a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver patch This PR is a semver patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants