Fix null body response to 404 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cditcher
requested changes
Jun 14, 2024
...n/java/ca/bc/gov/educ/api/course/model/transformer/EquivalentOrChallengeCodeTransformer.java
Show resolved
Hide resolved
cditcher
requested changes
Jun 14, 2024
| public EquivalentOrChallengeCode getEquivalentOrChallengeCode(String equivalentOrChallengeCode) { | ||
| return equivalentOrChallengeCodeTransformer.transformToDTO(equivalentOrChallengeCodeRepository.findById(equivalentOrChallengeCode)); | ||
| public EquivalentOrChallengeCode getEquivalentOrChallengeCode(String equivalentOrChallengeCode) throws EntityNotFoundException { | ||
| EquivalentOrChallengeCode result = equivalentOrChallengeCodeTransformer.transformToDTO(equivalentOrChallengeCodeRepository.findById(equivalentOrChallengeCode)); |
There was a problem hiding this comment.
Hi @arybakov-cgi looking way better, but to clarify, Transformer should not check if entity is present, it should only be concerned with transforming an entity. Please check if entity is present here in the service, if present, pass the entity to the transformer, not the optional. Then we should be good. Thanks!
|
cditcher
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.