Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed schoolOfRecord from payload #749

Merged
merged 2 commits into from
Jan 28, 2025
+1 −4
Merged

Removed schoolOfRecord from payload #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee3a2d2
Removed schoolOfRecord from payload
cditcher Jan 28, 2025
24b5d6b
Fixed unit test
cditcher Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .../ca/bc/gov/educ/api/gradstudent/messaging/jetstream/FetchGradStudentRecordSubscriber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ private String getResponse(GradStudentRecord studentRecord) throws JsonProcessin
.studentID(String.valueOf(studentRecord.getStudentID()))
.program(studentRecord.getProgram())
.programCompletionDate(studentRecord.getProgramCompletionDate() != null ? EducGradStudentApiUtils.formatDate(studentRecord.getProgramCompletionDate()) : null)
.schoolOfRecord(studentRecord.getSchoolOfRecord())
.schoolOfRecordId(String.valueOf(studentRecord.getSchoolOfRecordId()))
.studentStatusCode(studentRecord.getStudentStatus())
.graduated(gradStudentService.parseGraduationStatus(studentRecord.getStudentProjectedGradData()).toString())
Expand Down
1 change: 0 additions & 1 deletion api/src/main/java/ca/bc/gov/educ/api/gradstudent/model/dc/GradStudentRecordPayload.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ public class GradStudentRecordPayload {
private String exception;
private String program;
private String programCompletionDate;
private String schoolOfRecord;
private String schoolOfRecordId;
private String studentStatusCode;
private String graduated;
Expand Down
1 change: 0 additions & 1 deletion api/src/main/java/ca/bc/gov/educ/api/gradstudent/model/dto/messaging/GradStudentRecord.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ public class GradStudentRecord {
private UUID studentID;
private String program;
private Date programCompletionDate;
private String schoolOfRecord;
private UUID schoolOfRecordId;
private String studentStatus;
private String studentProjectedGradData;
Expand Down
2 changes: 1 addition & 1 deletion api/src/test/java/ca/bc/gov/educ/api/gradstudent/service/GradStudentServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,7 @@ public void testGetGraduationStudentRecord_GivenValidProgramCompletionDate_Expec
UUID studentID = UUID.randomUUID();
GraduationStudentRecordEntity graduationStudentRecordEntity = new GraduationStudentRecordEntity();
graduationStudentRecordEntity.setProgramCompletionDate(new java.util.Date());
when(graduationStatusRepository.findByStudentID(studentID, GradStudentRecord.class)).thenReturn(new GradStudentRecord(studentID, "2018-EN", new java.util.Date(), "schoolOfRecord", UUID.randomUUID(), "studentStatusCode", "{\"nonGradReasons\":null,\"graduated\":true}"));
when(graduationStatusRepository.findByStudentID(studentID, GradStudentRecord.class)).thenReturn(new GradStudentRecord(studentID, "2018-EN", new java.util.Date(), UUID.randomUUID(), "studentStatusCode", "{\"nonGradReasons\":null,\"graduated\":true}"));
GradStudentRecord result = gradStudentService.getGraduationStudentRecord(studentID);
assertNotNull(result);
}
Expand Down
Loading