Fix utm_convert()
#148
Merged
Fix utm_convert()
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* restore original class * Supply character vector to `split` to ensure order remains the same * Less cbind()ing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the output of
utm_convert()is the same as the input, except with the new spatial information.There were two main issues:
split()was splitting on a numeric column and thus was ordering the split sub data frames on that numeric, rather than respecting the order they were in in the original data.frame.cbind()ing unnecessarily in the reassembled data frame, because that could have been (and is now) delegated toconvert_from_zone()as it is run on each individual sub-dataframe separately.The cbinding of the original data frame with the reassembled sub data frames (which were reassembled not in order) resulted in a mismatch of rows.
Now in each sub data frame we keep the input columns, and cbind
XandYif they are asked for, then reassemble the sub-dataframes, in the order they were in in the orginal input.Finally, if an input was a
tibble, it is now returned as atibble.Closes #146; closes #143