CMS-437: Update URL paths, use resolvers #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncan-oxd
commented
Mar 1, 2025
Comment on lines
-371
to
372
| <NavBack routePath={`/park/${parkId}/edit/${seasonId}`}> | ||
| <NavBack routePath={paths.park(parkId)}> | ||
| Back to {data?.park.name} dates | ||
| </NavBack> |
There was a problem hiding this comment.
I also fixed this; these "NavBack" buttons should always go back to the Park details page, so it was incorrect here on the non-winter preview page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
CMS-437
Description
I couldn't find a way to resolve routes by a name or ID in React, so I've added a "paths" file with functions that take park/season IDs and return the URL paths.
This branch replaces all the hard-coded URL paths in all of the links and
navigatecalls, and uses the resolvers instead.I also updated the non-winter season URL paths to be consistent with the winter-fees, and made the resource names plural.
Previously:
Updated: