Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Code With Us QaQc Dashboard Dec 2023 #2109

Merged
merged 35 commits into from
Mar 14, 2024
Merged

[FEATURE] Code With Us QaQc Dashboard Dec 2023 #2109

merged 35 commits into from
Mar 14, 2024

Conversation

AlexZorkin
Copy link
Collaborator

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Added a new 'QaQc Dashboard' to the GWELLS Nav Bar. This is only visible to users with the edit role.
  • The QaQc Dashboard view contains 3 new tables accessible via selectable tabs 'Record Compliance', 'Mislocated Wells', and 'Cross Referencing'
  • Record Compliance: This table shows any well records that are missing required information.
  • Mislocated Wells: This table displays wells that have incongruent location data.
  • Cross Referencing: This table displays well records that have been cross referenced by the internal team.

note: This pr is still a work in progress and will be used for testing for the time being.

fergmac
fergmac reviewed Jan 16, 2024
View reviewed changes
@davidclaveau davidclaveau linked an issue Jan 26, 2024 that may be closed by this pull request
R Shiny Dashboard integration into GWELLS #2074
Closed
10 tasks
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@fergmac fergmac self-requested a review March 14, 2024 21:56
@AlexZorkin AlexZorkin merged commit 51fed58 into release Mar 14, 2024
8 of 9 checks passed
@AlexZorkin AlexZorkin deleted the feat/cwu-qaqc-dashboard-dec-2023 branch March 14, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fergmac fergmac fergmac approved these changes

Assignees
No one assigned
Labels
Backend Frontend Scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R Shiny Dashboard integration into GWELLS
3 participants
@AlexZorkin @fergmac @bcgov-csnr-cd