Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX][GWELLS-#2132] - Check if the $ref exists for activitySubmission, bug fix on Submit #2134

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

davidclaveau
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Check if the $ref.ActivitySubmission exists for form validation
  • Fix the error where isFormValid() is called on the final Submit where the component isn't rendered on the page (but the coordinates are valid and were submitted in the previous step).

Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@davidclaveau davidclaveau merged commit 9422c64 into release Feb 2, 2024
5 of 7 checks passed
@davidclaveau davidclaveau deleted the gwells-2132 branch February 2, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants