Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GWELLS-2050] FEATURE** Date export Endpoint DataBC #2143

Merged
merged 5 commits into from
Feb 8, 2024

Conversation

LocalNewsTV
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Added /api/v2/gis/aquifer-parameters endpoint to gwells api for exporting public data to DataBC
  • Most of the functionality is duplicated from other DataBC exports

Additional Notes

  • endpoints use realtime=True query string to pull live data vs stored date (existing functionality in previous export endpoints)

Copy link
Contributor

@acatchpole acatchpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good.
As it is well data that is being accessed here, i think that it would make more sense to to have this new endpoint defined in app/backend/wells rather than aquifers

Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LocalNewsTV LocalNewsTV merged commit 8356857 into release Feb 8, 2024
9 checks passed
@LocalNewsTV LocalNewsTV deleted the gwells-2050-data-export-endpoint branch February 8, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GWELLS API for pumping test and aquifer parameters
4 participants