Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE][GWELLS-2051] Added "Well - aquifer parameters" filter on the map on Aquifer Summary page and Aquifer Search Page #2144

Merged
merged 13 commits into from
Feb 8, 2024

Conversation

acatchpole
Copy link
Contributor

@acatchpole acatchpole commented Feb 6, 2024

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

postgis_ftw.gwells_well_view is what the map queries for wells. added a migration to update this view to include a boolean field that is true if the well_tag_number exists in the aquifer_parameters table, indicating that pumping test/aquifer parameter data exists for that well.

Added a new 'layer' filter wellsAquiferParameters() that checks this boolean and highlights the wells when true.

Removed the old aquifer parameters legend and check from the searchedWellsLayer()

image

Copy link
Contributor

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot get image to change when adding pumping test data. All dots remain the same in Openshift

@acatchpole
Copy link
Contributor Author

Cannot get image to change when adding pumping test data. All dots remain the same in Openshift

The move from local Docker to Openshift seems to be responsible for a not-insignificant delay (5-10min) in changes being being visible on the map.

Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@acatchpole acatchpole marked this pull request as ready for review February 8, 2024 18:32
@acatchpole acatchpole merged commit 6807b6f into release Feb 8, 2024
7 of 9 checks passed
@acatchpole acatchpole deleted the feat/gwells-2051 branch February 8, 2024 18:33
@acatchpole
Copy link
Contributor Author

merged to release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants