Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move Fuel Code validation to the back end #1879

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

dhaselhan
Copy link
Collaborator

  • Fuel code was using custom logic meaning it didnt get any of the yellow upgrades done previously
  • Remove the FE logic to Backend validation and let the errors go through the normal validation route

* Fuel code was using custom logic meaning it didnt get any of the yellow upgrades done previously
* Remove the FE logic to Backend validation and let the errors go through the normal validation route
@dhaselhan dhaselhan requested a review from AlexZorkin January 31, 2025 00:34
Copy link

github-actions bot commented Jan 31, 2025

Frontend Test Results

  1 files  ±0  125 suites  ±0   46s ⏱️ -1s
436 tests ±0  416 ✅ ±0  20 💤 ±0  0 ❌ ±0 
438 runs  ±0  418 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit e0ef9ff. ± Comparison against base commit d73419a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 31, 2025

Backend Test Results

524 tests  ±0   524 ✅ ±0   1m 52s ⏱️ -2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e0ef9ff. ± Comparison against base commit d73419a.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhaselhan dhaselhan merged commit 136e754 into release-1.0.0 Jan 31, 2025
11 checks passed
@dhaselhan dhaselhan deleted the fix/daniel-rebase-1684 branch January 31, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants