Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Clean up transaction history by removing draft entries - 1855 #1936

Merged

Conversation

hamed-valiollahi
Copy link
Collaborator

This PR removes the "Created draft" entry from transaction history and the "Draft" stage from the progress bar for a clearer, more accurate user experience.

Closes #1855

Copy link

github-actions bot commented Feb 6, 2025

Frontend Test Results

  1 files  ±0  125 suites  ±0   47s ⏱️ ±0s
436 tests ±0  416 ✅ ±0  20 💤 ±0  0 ❌ ±0 
438 runs  ±0  418 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 2a0c4e1. ± Comparison against base commit 7e49fdb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 6, 2025

Backend Test Results

530 tests  ±0   530 ✅ ±0   1m 49s ⏱️ -2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 2a0c4e1. ± Comparison against base commit 7e49fdb.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a backend solution might be better just so we're not sending unneeded data to the frontend.

@hamed-valiollahi
Copy link
Collaborator Author

I think a backend solution might be better just so we're not sending unneeded data to the frontend.

Thanks for your feedback, Alex. Please let me know if the PR is ready to merge.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for frontend solution.

@hamed-valiollahi hamed-valiollahi merged commit 5211e12 into release-1.0.0 Feb 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCFS - Created draft transfer history
2 participants