-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Clear Search Button #355
Conversation
Quality Gate passed for 'nr-omrr-transparency-frontend'Issues Measures |
@popkinj Looks good - just noticing that the number of filters is being cut off at the top of screen on mobile. |
There are a couple of issues I'm seeing:
|
Thanks for the feedback @dawnbcgov and @kdbelair . I'll take a look. |
The latest changes you have flagged in your latest update look good and are working well on my end. I understand you might be addressing these additional notes/observations in a different PR, but just flagging them here to keep track:
I also noted this, but this would also change on the text search page too:
|
Correct @kdbelair . I would like to merge my existing PRs before I address the button issues. :) |
Thanks @popkinj - approved. |
Working on these fixes now. |
@popkinj -The status, filter and find me buttons still look slightly thicker than the search bar on desktop. Can you take a quick look if it can be adjusted? Everything else looks great |
Confirming that the size of the icons has been fixed. Good to go from my end. |
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: