Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Clear Search Button #355

Merged
merged 23 commits into from
Jan 28, 2025
Merged

feat: New Clear Search Button #355

merged 23 commits into from
Jan 28, 2025

Conversation

popkinj
Copy link
Collaborator

@popkinj popkinj commented Jan 19, 2025

  • Button beside the sidebar title that clears both the search results and the text in the search title.
  • Hides when not searching anything

Screenshot from 2025-01-19 10-51-18
Screenshot from 2025-01-19 10-51-10


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@popkinj popkinj requested review from dawnbcgov and kdbelair January 19, 2025 18:52
@popkinj popkinj linked an issue Jan 19, 2025 that may be closed by this pull request
3 tasks
@popkinj popkinj linked an issue Jan 19, 2025 that may be closed by this pull request
3 tasks
@popkinj
Copy link
Collaborator Author

popkinj commented Jan 20, 2025

Screenshot from 2025-01-20 12-13-32
Screenshot from 2025-01-20 12-13-40

@popkinj popkinj marked this pull request as ready for review January 20, 2025 20:20
Copy link

@kdbelair
Copy link

@popkinj Looks good - just noticing that the number of filters is being cut off at the top of screen on mobile.
statuscutoff

@dawnbcgov
Copy link
Contributor

There are a couple of issues I'm seeing:

  • the buttons now are a different size than the search bar
  • It looks like the borders are 2px when they should be 1px
  • there is a white border now when active, which we don't need
  • it looks like the search tray names haven't been updated
  • I don't think the zoom on hover feels particularly clean
  • I think carrying over the notification to the other buttons is interesting, but I wonder why we stopped using the notification colour from the mockups? Also there are clipping issues on mobile as seen in Konane's screenshot

On PR:
image
image

On mockups:
image
image

@popkinj
Copy link
Collaborator Author

popkinj commented Jan 21, 2025

Thanks for the feedback @dawnbcgov and @kdbelair . I'll take a look.

@popkinj
Copy link
Collaborator Author

popkinj commented Jan 22, 2025

Latest updates:

  • Replace chip with red dot
  • Updated text in bottom draw to match the buttons (Search & Filter)
  • Removed the underline in the autosearch dropdown.
  • Removed the hover effect for the filter/search buttons

red_dot_desktop
red-dot-mobile

@kdbelair
Copy link

The latest changes you have flagged in your latest update look good and are working well on my end. I understand you might be addressing these additional notes/observations in a different PR, but just flagging them here to keep track:

  • the buttons are a different size than the search bar
  • It looks like the borders are 2px when they should be 1px
  • there is a white border now when active, which we don't need

I also noted this, but this would also change on the text search page too:

  • the filter name of "Land Application Biosolids" should be updated to "Land Application" as shown in the Figma

@popkinj
Copy link
Collaborator Author

popkinj commented Jan 22, 2025

The latest changes you have flagged in your latest update look good and are working well on my end. I understand you might be addressing these additional notes/observations in a different PR, but just flagging them here to keep track:

* the buttons are a different size than the search bar

* It looks like the borders are 2px when they should be 1px

* there is a white border now when active, which we don't need

I also noted this, but this would also change on the text search page too:

* the filter name of "Land Application Biosolids" should be updated to "Land Application" as shown in the Figma

Correct @kdbelair . I would like to merge my existing PRs before I address the button issues. :)

@kdbelair
Copy link

Thanks @popkinj - approved.

@popkinj
Copy link
Collaborator Author

popkinj commented Jan 27, 2025

Working on these fixes now.

@popkinj
Copy link
Collaborator Author

popkinj commented Jan 27, 2025

I could probably tweak these styles all week long hahaha.
Think things are looking good now.
Screenshot from 2025-01-27 11-20-59
Screenshot from 2025-01-27 11-25-59

@kdbelair
Copy link

@popkinj -The status, filter and find me buttons still look slightly thicker than the search bar on desktop. Can you take a quick look if it can be adjusted? Everything else looks great

@kdbelair
Copy link

Confirming that the size of the icons has been fixed. Good to go from my end.

@popkinj popkinj merged commit 904c309 into main Jan 28, 2025
20 checks passed
@popkinj popkinj deleted the map/filters-256 branch January 28, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants