-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Authorization Details Style Updates #371
Conversation
A few notes as I am reviewing what makes sense to include in terms of links and text (see Figma mockups for context):
|
|
|
Think the missing status records have to do with a typo in one of the backend scripts. Testing a fix now. |
Alrighty... I can see the status records now. Have a look and let me know what you think. |
|
Just picking up on this one comment -- that feedback was given when the web page was zoomed in quite significantly. I believe the heading is the same weight as others, so if that change is made it should be reflected across the other headings. |
Thank @popkinj, could we please:
|
|
@kdbelair - This should be ready as well |
All the latest stuff should be in this PR now @kdbelair. Let me know if you have trouble seeing the latest changes. |
@popkinj - Cleared cache, used private windows/incognito and not seeing the changes on this PR. |
Oh.... I see what you mean now. For some reason this PR didn't rebase properly. |
OK... Think I know what is happening @kdbelair . |
Looks like I can see the updates now. Updated comments based on what i see now:
|
And a little bug fix:
|
@popkinj - A small edit that we need to change the italicized text screenshotted below to the secondary colour. Everything else looks great. |
Done. |
approved |
Hey @mishraomp . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Reworked the Authorization Details.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: