Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Authorization Details Style Updates #371

Merged
merged 29 commits into from
Feb 13, 2025
Merged

refactor: Authorization Details Style Updates #371

merged 29 commits into from
Feb 13, 2025

Conversation

popkinj
Copy link
Contributor

@popkinj popkinj commented Jan 30, 2025

Reworked the Authorization Details.

Screenshot from 2025-01-30 13-11-11


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@popkinj
Copy link
Contributor Author

popkinj commented Jan 30, 2025

Restyling the notifications.
Screenshot from 2025-01-30 14-40-08
Screenshot from 2025-01-30 14-41-07
Screenshot from 2025-01-30 14-41-18

@popkinj popkinj marked this pull request as ready for review January 30, 2025 22:43
@popkinj popkinj changed the title refactor: This looks like the mockup now refactor: Authorization Details Style Updates Jan 30, 2025
@kdbelair
Copy link

kdbelair commented Jan 30, 2025

A few notes as I am reviewing what makes sense to include in terms of links and text (see Figma mockups for context):

  • Retain the text and link at the bottom of the application status area "Applies to amendment and new notifications only, please see our guidance on data we show" (link to be provided at a later date when page is live).
  • Include the following text and link under application Status "Learn more (https://www2.gov.bc.ca/gov/content/environment/waste-management/waste-discharge-authorization) about amendments, notifications and authorizations)
  • Including a blurb under each permit, operational certificate ect is not needed as we don't have summaries that would be a good fit on our pages at this time.

@popkinj
Copy link
Contributor Author

popkinj commented Jan 31, 2025

A few notes as I am reviewing what makes sense to include in terms of links and text (see Figma mockups for context):

* Retain the text and link at the bottom of the application status area  "Applies to amendment and new notifications only, please see our guidance on data we show"   (link to be provided at a later date when page is live).

* Include the following text and link under application Status "Learn more (https://www2.gov.bc.ca/gov/content/environment/waste-management/waste-discharge-authorization) about amendments, notifications and authorizations)

* Including a blurb under each permit, operational certificate ect is not needed as we don't have summaries that would be a good fit on our pages at this time.

How does this look.
Screenshot from 2025-01-31 09-36-02

@kdbelair
Copy link

  • The Application status is not showing up on authorizations I would expect them to show up. For example, auths # 108536, 108531 and 108485 all show up with a status on organicsinfo.gov.bc.ca but not on these test pages (see screenshot below).
  • I now have the link that we want to include in the text at the bottom of the application status area. I would like to tweak the language a bit to match up with what we expect to show on the external webpage to the following "Applies to applications for amendments only, please see our website on data we show.

permit status

@popkinj
Copy link
Contributor Author

popkinj commented Jan 31, 2025

  • The Application status is not showing up on authorizations I would expect them to show up. For example, auths # 108536, 108531 and 108485 all show up with a status on organicsinfo.gov.bc.ca but not on these test pages (see screenshot below).

    • I now have the link that we want to include in the text at the bottom of the application status area. I would like to tweak the language a bit to match up with what we expect to show on the external webpage to the following "Applies to applications for amendments only, please see our website on data we show.

permit status

Think the missing status records have to do with a typo in one of the backend scripts. Testing a fix now.
The link you posted is for Ammendment records only right? And can you double check the link for me.
Screenshot from 2025-01-31 13-30-14

@popkinj
Copy link
Contributor Author

popkinj commented Jan 31, 2025

Alrighty... I can see the status records now. Have a look and let me know what you think.

@kdbelair
Copy link

kdbelair commented Feb 1, 2025

  • Status records are working well on my end now
  • Not all are authorization amendments. They are tied to the authorization type, which is shown in the Authorization Details on each page. For 108536, It should read "Permit" instead of "Authorization Amendment", for 108531, it should read "Operational Certificate" instead of "Authorization Amendment"
  • I must have copied the wrong link for the "Learn more" link, it should be https://www2.gov.bc.ca/gov/content/environment/waste-management/waste-discharge-authorization
  • I can confirm that the text I provided for the second link is correct. It is broken at this time, but that is where the webpage will live when it goes. I still see the old text on the page, it should be: "Applies to applications for amendments only, please see our website on data we show. I would also like to have the font size on this disclaimer match the size of the text that is under the "Application Status" heading.
  • We have been doing some testing interviews over the last few days, and one interviewer noted that the "Application Status" heading was rather small, so I would like to see it increased.

@dawnbcgov
Copy link
Contributor

  • We have been doing some testing interviews over the last few days, and one interviewer noted that the "Application Status" heading was rather small, so I would like to see it increased.

Just picking up on this one comment -- that feedback was given when the web page was zoomed in quite significantly. I believe the heading is the same weight as others, so if that change is made it should be reflected across the other headings.

@popkinj
Copy link
Contributor Author

popkinj commented Feb 4, 2025

Updates from latest PR feedback
Screenshot from 2025-02-04 11-07-18
Screenshot from 2025-02-04 11-09-17
Screenshot from 2025-02-04 11-22-29
Screenshot from 2025-02-04 11-22-44

@kdbelair
Copy link

kdbelair commented Feb 4, 2025

Thank @popkinj, could we please:

  • Increase the font size of "Learn more about amendments, notifications and authorizations" to match "Applies to amendment and new notifications only, please see our guidance on data we show."
  • Update the text from "Applies to amendment and new notifications only, please see our guidance on data we show." to "Applies to amendments and new notifications only, please see our website on data we show."
  • The link in the for the text "Learn more about amendments, notifications and authorizations" needs to be updated to: https://www2.gov.bc.ca/gov/content/environment/waste-management/waste-discharge-authorization
  • The Compliance and Enforcement Section should have a "grey box" around it, just like it does for Authorization Details, Documents, ect. I think this was present earlier but has disappeared on this PR.
  • The heading for "FacIlity Location" has a capitalized "i", Please update to "Facility Location"
  • For notifications on compost facilities, we want to tweak the language based on feedback:
  • Update text "The information presented was provided by the proponent at the time of submission" to "The information presented was provided by the proponent at the time of submission. Please see Schedule 12 of the Organic Matter Recycling Regulation for a list of Organic Matter Suitable for Composting."
  • Update the text "Known matter accepted" to "Types of organic matter accepted"
  • Update text "Known matter not accepted" to "Types of organic matter not accepted" Please have the word "not" underlined, as I cant figure out how to do that here in the comments section.

@popkinj
Copy link
Contributor Author

popkinj commented Feb 7, 2025

  • Increase the font size of "Learn more about amendments, notifications and authorizations" to match "Applies to amendment and new notifications only, please see our guidance on data we show."

  • Update the text from "Applies to amendment and new notifications only, please see our guidance on data we show." to "Applies to amendments and new notifications only, please see our website on data we show."

  • The link in the for the text "Learn more about amendments, notifications and authorizations" needs to be updated to: https://www2.gov.bc.ca/gov/content/environment/waste-management/waste-discharge-authorization

  • The Compliance and Enforcement Section should have a "grey box" around it, just like it does for Authorization Details, Documents, ect. I think this was present earlier but has disappeared on this PR.

  • The heading for "FacIlity Location" has a capitalized "i", Please update to "Facility Location"

  • For notifications on compost facilities, we want to tweak the language based on feedback:

Update text "The information presented was provided by the proponent at the time of submission" to "The information presented was provided by the proponent at the time of submission. Please see Schedule 12 of the Organic Matter Recycling Regulation for a list of Organic Matter Suitable for Composting."

  • Update the text "Known matter accepted" to "Types of organic matter accepted"

  • Update text "Known matter not accepted" to "Types of organic matter not accepted" Please have the word "not" underlined, as I cant figure out how to do that here in the comments section.

Sorry, something went wrong.

@popkinj
Copy link
Contributor Author

popkinj commented Feb 7, 2025

@kdbelair - This should be ready as well

@popkinj
Copy link
Contributor Author

popkinj commented Feb 7, 2025

All the latest stuff should be in this PR now @kdbelair. Let me know if you have trouble seeing the latest changes.

@kdbelair
Copy link

kdbelair commented Feb 7, 2025

@popkinj - Cleared cache, used private windows/incognito and not seeing the changes on this PR.

@popkinj
Copy link
Contributor Author

popkinj commented Feb 7, 2025

@popkinj - Cleared cache, used private windows/incognito and not seeing the changes on this PR.

Oh.... I see what you mean now. For some reason this PR didn't rebase properly.

@popkinj
Copy link
Contributor Author

popkinj commented Feb 7, 2025

@popkinj - Cleared cache, used private windows/incognito and not seeing the changes on this PR.

Oh.... I see what you mean now. For some reason this PR didn't rebase properly.

OK... Think I know what is happening @kdbelair .
The rebase is intentionally not complete. For items other then this PR you can go here https://nr-epd-organics-info-prod-frontend.apps.silver.devops.gov.bc.ca/ Sorry for the mixup.

@kdbelair
Copy link

kdbelair commented Feb 11, 2025

Looks like I can see the updates now. Updated comments based on what i see now:

  • Update the disclaimer in the Compliance and Enforcement Section to: "Compliance and enforcement data presented is from the Natural Resource Compliance and Enforcement Database and may not be complete. The information shown is based on a search using the authorization number and the name of the regulated party."
  • I think the text colour in the application status is a mix of grey and black, please update for consistency, the font size looks good now.
  • For notifications on compost facilities, we are missing the link for the 'Schedule 12' text: https://www.bclaws.gov.bc.ca/civix/document/id/complete/statreg/18_2002#Schedule12

@popkinj
Copy link
Contributor Author

popkinj commented Feb 12, 2025

  • Update the disclaimer in the Compliance and Enforcement Section to: "Compliance and enforcement data presented is from the Natural Resource Compliance and Enforcement Database and may not be complete. The information shown is based on a search using the authorization number and the name of the regulated party."
  • I think the text colour in the application status is a mix of grey and black, please update for consistency, the font size looks good now. (Think I got the right spot??)
  • For notifications on compost facilities, we are missing the link for the 'Schedule 12' text: https://www.bclaws.gov.bc.ca/civix/document/id/complete/statreg/18_2002#Schedule12

And a little bug fix:

  • I think somehow in one of the PRs we broke how the Type of Compost Produced is displayed, right now nothing shows up, but we stil have that key in the data

Sorry, something went wrong.

@kdbelair
Copy link

@popkinj - A small edit that we need to change the italicized text screenshotted below to the secondary colour. Everything else looks great.
secondary colour

@popkinj
Copy link
Contributor Author

popkinj commented Feb 12, 2025

@popkinj - A small edit that we need to change the italicized text screenshotted below to the secondary colour. Everything else looks great. secondary colour

Done.

@kdbelair
Copy link

approved

@popkinj
Copy link
Contributor Author

popkinj commented Feb 12, 2025

Hey @mishraomp .
When you get the chance, this PR is ready for your review/approval. :)

Copy link
Contributor

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mishraomp mishraomp merged commit 1896dd6 into main Feb 13, 2025
20 checks passed
@mishraomp mishraomp deleted the auth-238c branch February 13, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth Details > Rethink of whole application status section at the top of the authorization detail page
4 participants