Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type): implemented resource type #319

Merged
merged 6 commits into from
Feb 6, 2025
Merged

Conversation

hamidhabib-buttons
Copy link
Contributor

Implemented Resource Type data model and UI component

Description

Screenshot 2025-02-04 at 8 21 31 AM

Fixes # (266)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Navigate to a resource page
  • Click on specific site or trail
  • Check the resource type information is available

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

@hamidhabib-buttons hamidhabib-buttons self-assigned this Feb 4, 2025
@hamidhabib-buttons hamidhabib-buttons marked this pull request as ready for review February 4, 2025 14:18
Copy link
Contributor

@marcellmueller marcellmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! The implementation looks sound. Just a couple thoughts:

  • What was your reasoning for keeping this in the same recreation_map_feature table that the old database uses? I know Jimmy brought up just having the code on the main recreation_resource table since it's a key piece of information and just a one to one relationship.

  • We still need an insert statement to import the prod data from the fta schema to our rst schema in /migrations/fta/sql/V1.0.2__fta_to_rst.sql.

Copy link
Contributor

@marcellmueller marcellmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this and thanks for the updates! 🙇

@hamidhabib-buttons hamidhabib-buttons merged commit ff23416 into main Feb 6, 2025
31 checks passed
@hamidhabib-buttons hamidhabib-buttons deleted the site-resource-type branch February 6, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants