-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(type): implemented resource type #319
Conversation
4a31543
to
a22187b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this! The implementation looks sound. Just a couple thoughts:
-
What was your reasoning for keeping this in the same
recreation_map_feature
table that the old database uses? I know Jimmy brought up just having the code on the mainrecreation_resource
table since it's a key piece of information and just a one to one relationship. -
We still need an insert statement to import the prod data from the fta schema to our rst schema in
/migrations/fta/sql/V1.0.2__fta_to_rst.sql
.
migrations/fixtures/sql/V1.0.4__recreation_map_feature_code.sql
Outdated
Show resolved
Hide resolved
166cc9c
to
73b76c4
Compare
92749b0
to
f84c06b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this and thanks for the updates! 🙇
Implemented Resource Type data model and UI component
Description
Fixes # (266)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist