feat(trail): add number of campsites to trail #340
+187
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,8 @@ create table if not exists rst.recreation_resource ( | |||
| description varchar(5000), | |||
| closest_community varchar(200), | |||
| display_on_public_site boolean default false, | |||
| rec_resource_type varchar(50) | |||
| rec_resource_type varchar(50), | |||
| campsite_count integer default 0 | |||
There was a problem hiding this comment.
Should we be storing a count of this as a column in the database or just query the count of defined campsites as we need them? This would work for MVP but we'd likely have to refactor it assuming there is a defined campsites section in the upcoming admin app.
There was a problem hiding this comment.
The reason I put this alone as a single column is to avoid any unnecessary data storage in the recreation_resource table. For admin app, we can probably create another table and then just reference the table here in recreation_resource
hamidhabib-buttons
force-pushed
the
campsite-count-number
branch
from
e01b629 to
17a6b38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature adds number of campsites to a specific trail.
Fixes # (267)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist