feat: removed dependency on terraform batch jobs to apply integrations to keycloak #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NithinKuruba
requested review from
thegentlemanphysicist and
arcshiftsolutions
as code owners
Terraform Format and Style 🖌
|
jlangy
reviewed
Jan 2, 2024
lambda/app/src/github.ts
Outdated
| @@ -88,7 +89,7 @@ export const buildGitHubRequestData = (baseData: IntegrationData) => { | |||
| return baseData; | |||
| }; | |||
|
|
|||
| export const dispatchRequestWorkflow = async (integration: any) => { | |||
| export const dispatchRequestWorkflow = async (integration: any, restore: boolean = false) => { | |||
There was a problem hiding this comment.
We should maybe change the name of this function since it doesn;t use github actions anymore, maybe something like createClient
There was a problem hiding this comment.
Yeah we do not need github file anymore so moved all the code to requests controller file and renamed the function to processIntegrationRequest
lambda/db/src/migrations/2023.12.25T01.00.00.create-request-roles-table.ts
Show resolved
Hide resolved
lambda/app/src/controllers/user.ts
Outdated
|
|
||
| await disableIntegration(rqst.get({ plain: true, clone: true })); | ||
| await closeOpenPullRequests(rqst.id); | ||
| await dispatchRequestWorkflow(rqst); | ||
| //await closeOpenPullRequests(rqst.id); |
There was a problem hiding this comment.
We can probably remove this commented line
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
thegentlemanphysicist
previously approved these changes
Jan 3, 2024
jlangy
previously approved these changes
Jan 3, 2024
NithinKuruba
dismissed stale reviews from jlangy and thegentlemanphysicist
via
dda04e7
|
Terraform Format and Style 🖌
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes below tickets