Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor tweaks #1102

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: minor tweaks #1102

merged 1 commit into from
Jan 3, 2024

Conversation

NithinKuruba
Copy link
Contributor

  1. Handle client id update for SAML integrations
  2. Set login theme for SAML integrations
  3. Enable restore only for integrations with Applied and Deleted/Archived statuses

@NithinKuruba NithinKuruba added the bug Something isn't working label Jan 3, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan 

terraform

Pusher: @NithinKuruba, Action: pull_request

thegentlemanphysicist
thegentlemanphysicist approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@thegentlemanphysicist thegentlemanphysicist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@NithinKuruba NithinKuruba merged commit 6bfcb7e into dev Jan 3, 2024
9 checks passed
@NithinKuruba NithinKuruba deleted the fix/SSOTEAM-1084-01 branch January 3, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegentlemanphysicist thegentlemanphysicist thegentlemanphysicist approved these changes

@arcshiftsolutions arcshiftsolutions Awaiting requested review from arcshiftsolutions arcshiftsolutions is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NithinKuruba @thegentlemanphysicist