Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run queued client requests on a schedule #1103

Merged
merged 12 commits into from
Jan 5, 2024
Merged

feat: run queued client requests on a schedule #1103

merged 12 commits into from
Jan 5, 2024

Conversation

jlangy
Copy link
Contributor

@jlangy jlangy commented Jan 4, 2024

run requests in the queue on a schedule. Two notes:

  • I chose 5 minutes as the interval a bit randomly, can make it more or less but seems appropriate
  • If an environment fails, the request will stay in the queue and rerun all envs. I think this is fine because that function you have written keycloakClient seems idempotent. I could kick some envs out of the array too though if you think it might cause an issue

jlangy added 2 commits January 4, 2024 14:34
run requests in the queue on a schedule
variable names and remove redundent call
Copy link

github-actions bot commented Jan 4, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @jlangy, Action: pull_request

sonar recomendations
Copy link

github-actions bot commented Jan 4, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @jlangy, Action: pull_request

Copy link

github-actions bot commented Jan 5, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @jlangy, Action: pull_request

jlangy added 2 commits January 5, 2024 11:59
resolve merge
fix bugs from merge
Copy link

github-actions bot commented Jan 5, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @jlangy, Action: pull_request

update email logic for request queue
Copy link

github-actions bot commented Jan 5, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @jlangy, Action: pull_request

add readme and comments
Copy link

github-actions bot commented Jan 5, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @jlangy, Action: pull_request

implement sonar recomendations
Copy link

github-actions bot commented Jan 5, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @jlangy, Action: pull_request

add back line lost in merge
Copy link

github-actions bot commented Jan 5, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @jlangy, Action: pull_request

remove unused variable
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Jan 5, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @jlangy, Action: pull_request

@jlangy jlangy merged commit c0cd563 into dev Jan 5, 2024
8 checks passed
@jlangy jlangy deleted the ssoteam-1385 branch January 5, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants