feat: added switch to enable/disable offline access for new clients #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NithinKuruba
requested review from
thegentlemanphysicist and
arcshiftsolutions
as code owners
Terraform Format and Style 🖌
|
NithinKuruba
added
feature
enhancement
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1182 +/- ##
==========================================
+ Coverage 71.16% 71.27% +0.10%
==========================================
Files 299 301 +2
Lines 10338 10447 +109
Branches 2400 2456 +56
==========================================
+ Hits 7357 7446 +89
- Misses 2981 3001 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* chore: update migrator add migrator args * chore: update deps update e2e deps
Terraform Format and Style 🖌
|
1 similar comment
Terraform Format and Style 🖌
|
| await kcAdminClient.clients.addOptionalClientScope({ | ||
| id: client.id, | ||
| clientScopeId: clientScopeList.find((defaultClientscope) => defaultClientscope.name === 'offline_access')?.id, | ||
| realm, | ||
| }); | ||
| } else { |
There was a problem hiding this comment.
Should we collapse this else/if to one line?
| id: client.id, | ||
| realm, | ||
| mapperId: additionalClientRolesMapper?.id, | ||
| }); | ||
| } | ||
| } else if (integration.protocol === 'saml') { |
There was a problem hiding this comment.
Maybe collapse these nested ifs to 1 line.
| @@ -330,7 +361,7 @@ export const keycloakClient = async ( | |||
| } | |||
| } | |||
| } else { | |||
arcshiftsolutions
previously approved these changes
Apr 22, 2024
|
Terraform Format and Style 🖌
|
arcshiftsolutions
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new switch added to each environment in request integration form to enable/disable offline access. This applies to only new integrations and existing ones are grandfathered in, i.e. enabled by default.
This also fixes the issue with additional_client_roles where the mapper was not getting updated with new name.