Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a flag for first stage of form #1183

Merged
merged 11 commits into from
Apr 22, 2024
Merged

Conversation

thegentlemanphysicist
Copy link
Contributor

No description provided.

Copy link

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @thegentlemanphysicist, Action: pull_request

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.17%. Comparing base (94a6bb4) to head (1007bf0).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1183      +/-   ##
==========================================
+ Coverage   71.16%   71.17%   +0.01%     
==========================================
  Files         299      299              
  Lines       10338    10342       +4     
  Branches     2400     2402       +2     
==========================================
+ Hits         7357     7361       +4     
  Misses       2981     2981              
Flag Coverage Δ
unitests 71.17% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @thegentlemanphysicist, Action: pull_request

Copy link
Contributor

@jlangy jlangy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I'm just looking into why that test is faliing

@jlangy jlangy closed this Apr 22, 2024
@jlangy jlangy reopened this Apr 22, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @jlangy, Action: pull_request

@thegentlemanphysicist thegentlemanphysicist merged commit a4dfaef into dev Apr 22, 2024
10 of 12 checks passed
@thegentlemanphysicist thegentlemanphysicist deleted the SSOTEAM-1569 branch April 22, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants