Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update migrator #1184

Merged
merged 2 commits into from
Apr 22, 2024
Merged

chore: update migrator #1184

merged 2 commits into from
Apr 22, 2024

Conversation

jlangy
Copy link
Contributor

@jlangy jlangy commented Apr 22, 2024

add migrator args

add migrator args
update e2e deps
@jlangy jlangy added the bug Something isn't working label Apr 22, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖``

Terraform Plan 📖success

Show Plan

terraform

Pusher: @jlangy, Action: pull_request

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.16%. Comparing base (94a6bb4) to head (591059e).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1184   +/-   ##
=======================================
  Coverage   71.16%   71.16%           
=======================================
  Files         299      299           
  Lines       10338    10338           
  Branches     2400     2400           
=======================================
  Hits         7357     7357           
  Misses       2981     2981           
Flag Coverage Δ
unitests 71.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlangy jlangy merged commit e65099a into dev Apr 22, 2024
9 of 10 checks passed
@jlangy jlangy deleted the fix/e2e-test branch April 22, 2024 22:55
NithinKuruba pushed a commit that referenced this pull request Apr 22, 2024
* chore: update migrator

add migrator args

* chore: update deps

update e2e deps
NithinKuruba added a commit that referenced this pull request Apr 23, 2024
…1182)

* feat: add offlineaccessenabled and fixed additional attribute bug

* feat: updated unit tests

* feat: omit offline session fields upon scope disabled

* feat: grandfather existing clients

* feat: removed console statements

* chore: update migrator (#1184)

* chore: update migrator

add migrator args

* chore: update deps

update e2e deps

* feat: merged some if/else blocks

---------

Co-authored-by: Jonathan Langlois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants