feat/DEVSU-2433 Add checkbox for option to create GraphKB user when create new IPR user #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bnguyen-bcgsc
commented
Aug 14, 2024
bnguyen-bcgsc
commented
- Needs DEVSU-2425 to work [https://github.com/Feature/devsu 2425 create graphkb user when add user pori_ipr_api#378]
- Add checkbox for option to create new graphkb user in add edit user dialog
- Revise scss to reflect new addition to dialog
- Add checkbox for option to create new graphkb user in add edit user dialog - Revise scss to reflect new addition to dialog
kttkjl
reviewed
Aug 16, 2024
app/views/AdminView/components/Users/components/AddEditUserDialog/index.scss
Outdated
Show resolved
Hide resolved
kttkjl
reviewed
Aug 16, 2024
app/views/AdminView/components/Users/components/AddEditUserDialog/index.tsx
Outdated
Show resolved
Hide resolved
kttkjl
reviewed
Aug 16, 2024
| @@ -442,7 +448,15 @@ const AddEditUserDialog = ({ | |||
| </div> | |||
| )} | |||
| </DialogContent> | |||
| <DialogActions className="edit-dialog__actions"> | |||
| <DialogActions className="add-user__actions"> | |||
There was a problem hiding this comment.
What's the rationale putting this on the actions instead of the actual form?
There was a problem hiding this comment.
it was solely for layout reasons but yea I can move it
elewis2
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.